Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a warning for decimal PKs with SqlServer #17817

Closed
AndriySvyryd opened this issue Sep 12, 2019 · 1 comment · Fixed by #21713
Closed

Add a warning for decimal PKs with SqlServer #17817

AndriySvyryd opened this issue Sep 12, 2019 · 1 comment · Fixed by #21713
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-3.1 type-enhancement
Milestone
5.0.0

Comments

@AndriySvyryd
Copy link
Member

AndriySvyryd commented Sep 12, 2019 •
edited
Loading

We use strict comparisons for PK values that can fail in some scenarios: #14952, #6835

Same for concurrency tokens #17799

Consider recommending to use SET NUMERIC_ROUNDABORT ON
@divega divega added this to the 3.1.0 milestone Sep 16, 2019
@divega
Copy link
Contributor

divega commented Sep 16, 2019

Triage: We should avoid breaking changes in 3.1, but we are not sure this would be one.

@ajcvickers ajcvickers modified the milestones: 3.1.0, Backlog Oct 11, 2019
@AndriySvyryd AndriySvyryd modified the milestones: Backlog, 5.0.0 Mar 20, 2020
AndriySvyryd added a commit that referenced this issue Jul 21, 2020
@AndriySvyryd
Add a warning for decimal keys for SqlServer
2e9f7cc 
Fixes #17817
@AndriySvyryd AndriySvyryd mentioned this issue Jul 21, 2020
Merged
@AndriySvyryd AndriySvyryd added closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. and removed poachable labels Jul 21, 2020
@AndriySvyryd AndriySvyryd removed their assignment Jul 21, 2020
AndriySvyryd added a commit that referenced this issue Jul 21, 2020
@AndriySvyryd
Add a warning for decimal keys for SqlServer
9b87eea 
Fixes #17817
AndriySvyryd added a commit that referenced this issue Jul 21, 2020
@AndriySvyryd
Add a warning for decimal keys for SqlServer
a314cf7 
Fixes #17817
@ghost ghost closed this as completed in #21713 Jul 21, 2020
ghost pushed a commit that referenced this issue Jul 21, 2020
@AndriySvyryd
Add a warning for decimal keys for SqlServer (#21713)
139cedd 
Fixes #17817
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-rc1 Aug 14, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-rc1, 5.0.0 Nov 7, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-3.1 type-enhancement
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Add a warning for decimal keys for SqlServer dotnet/efcore
3 participants
@divega @ajcvickers @AndriySvyryd