Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: allow user functions to be annotated with nullability propagation information #19609

Closed
maumar opened this issue Jan 16, 2020 · 1 comment · Fixed by #21777
Closed

Query: allow user functions to be annotated with nullability propagation information #19609

maumar opened this issue Jan 16, 2020 · 1 comment · Fixed by #21777
Assignees
@maumar
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. needs-design type-enhancement
Milestone
5.0.0

Comments

@maumar
Copy link
Contributor

maumar commented Jan 16, 2020 •
edited
Loading

Related to #18555

We should allow users to specify nullability propagation info for their custom functions, so that we can generate better SQL when those functions are compared to null
@maumar maumar modified the milestones: 3.1.x, 5.0.0 Jan 16, 2020
@maumar maumar self-assigned this Jan 16, 2020
@maumar maumar mentioned this issue Jan 16, 2020
Merged
@maumar maumar mentioned this issue Jan 28, 2020
Closed
@smitpatel
Copy link
Contributor

  • Add model level validation if user has not configured nullability information when there is no HasTranslation.

maumar added a commit that referenced this issue Jul 24, 2020
@maumar
Fix to #19609 - Query: allow user functions to be annotated with null…
780d5a2 
…ability propagation information

Added fluent API for function to specify it's nullability and function parameter to specify whether it propagates null. Also added property to DbFunction attribute to allow specify nullability there.
maumar added a commit that referenced this issue Jul 24, 2020
@maumar
Fix to #19609 - Query: allow user functions to be annotated with null…
9067e11 
…ability propagation information

Added fluent API for function to specify it's nullability and function parameter to specify whether it propagates null. Also added property to DbFunction attribute to allow specify nullability there.
@maumar maumar mentioned this issue Jul 24, 2020
Merged
@maumar maumar added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jul 24, 2020
maumar added a commit that referenced this issue Jul 24, 2020
@maumar
Fix to #19609 - Query: allow user functions to be annotated with null…
e41b11c 
…ability propagation information

Added fluent API for function to specify it's nullability and function parameter to specify whether it propagates null. Also added property to DbFunction attribute to allow specify nullability there.
maumar added a commit that referenced this issue Jul 25, 2020
@maumar
Fix to #19609 - Query: allow user functions to be annotated with null…
367b149 
…ability propagation information

Added fluent API for function to specify it's nullability and function parameter to specify whether it propagates null. Also added property to DbFunction attribute to allow specify nullability there.
maumar added a commit that referenced this issue Jul 27, 2020
@maumar
Fix to #19609 - Query: allow user functions to be annotated with null…
f53fe59 
…ability propagation information

Added fluent API for function to specify it's nullability and function parameter to specify whether it propagates null. Also added property to DbFunction attribute to allow specify nullability there.
maumar added a commit that referenced this issue Jul 27, 2020
@maumar
Fix to #19609 - Query: allow user functions to be annotated with null…
292f133 
…ability propagation information

Added fluent API for function to specify it's nullability and function parameter to specify whether it propagates null. Also added property to DbFunction attribute to allow specify nullability there.
maumar added a commit that referenced this issue Jul 27, 2020
@maumar
Fix to #19609 - Query: allow user functions to be annotated with null…
50f41ad 
…ability propagation information

Added fluent API for function to specify it's nullability and function parameter to specify whether it propagates null. Also added property to DbFunction attribute to allow specify nullability there.
maumar added a commit that referenced this issue Jul 27, 2020
@maumar
Fix to #19609 - Query: allow user functions to be annotated with null…
9046e12 
…ability propagation information (#21777)

Added fluent API for function to specify it's nullability and function parameter to specify whether it propagates null. Also added property to DbFunction attribute to allow specify nullability there.
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-rc1 Aug 14, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-rc1, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maumar maumar

Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. needs-design type-enhancement
Projects
None yet
Milestone
5.0.0
3 participants
@ajcvickers @smitpatel @maumar