Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Convert to AssertQuery in tests as much as possible #21393

Closed
3 tasks done
smitpatel opened this issue Jun 24, 2020 · 1 comment · Fixed by #22994
Closed
3 tasks done

Query: Convert to AssertQuery in tests as much as possible #21393

smitpatel opened this issue Jun 24, 2020 · 1 comment · Fixed by #22994
Assignees
@maumar
Labels
area-query area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
6.0.0

Comments

@smitpatel
Copy link
Contributor

smitpatel commented Jun 24, 2020 •
edited by maumar
Loading

  • InheritanceQueryTestBase
  • QueryFilters tests (northwind and inheritance models)
  • AsyncGearsOfWarQueryTestBase and merge it with GearsOfWarQueryTestBase
@maumar maumar self-assigned this Jun 24, 2020
@ajcvickers ajcvickers added this to the Backlog milestone Jun 26, 2020
@AndriySvyryd AndriySvyryd mentioned this issue Sep 5, 2020
Closed
@ajcvickers ajcvickers modified the milestones: Backlog, MQ Sep 11, 2020
@maumar
Copy link
Contributor

maumar commented Oct 6, 2020

also enable for Filtered_include_outer_parameter_used_inside_filter

maumar added a commit that referenced this issue Oct 10, 2020
@maumar
Fix to #21393 - Query: Convert to AssertQuery in tests as much as pos…
68f9f1e 
…sible

- adding visitor that rewrites expected query based on query filter model information,
- incorporating async GoW tests into the regular GoW test suite,
- converted query filter tests to AsserQuery infra
maumar added a commit that referenced this issue Oct 10, 2020
@maumar
Fix to #21393 - Query: Convert to AssertQuery in tests as much as pos…
313000d 
…sible

- adding visitor that rewrites expected query based on query filter model information,
- incorporating async GoW tests into the regular GoW test suite,
- converted query filter tests to AsserQuery infra
maumar added a commit that referenced this issue Oct 10, 2020
@maumar
Fix to #21393 - Query: Convert to AssertQuery in tests as much as pos…
0f49469 
…sible

- adding visitor that rewrites expected query based on query filter model information,
- incorporating async GoW tests into the regular GoW test suite,
- converted query filter tests to AsserQuery infra

Fixes #21393
@maumar maumar mentioned this issue Oct 10, 2020
Closed
@maumar maumar added closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. and removed consider-for-current-release labels Oct 10, 2020
maumar added a commit that referenced this issue Oct 10, 2020
@maumar
Fix to #21393 - Query: Convert to AssertQuery in tests as much as pos…
67016e3 
…sible

- adding visitor that rewrites expected query based on query filter model information,
- incorporating async GoW tests into the regular GoW test suite,
- converted query filter tests to AsserQuery infra

Fixes #21393
maumar added a commit that referenced this issue Oct 14, 2020
@maumar
Fix to #21393 - Query: Convert to AssertQuery in tests as much as pos…
7daef93 
…sible

added support for query filters to the AssertQuery test infra (using AssertFilteredQuery methods) and converted query filter tests to take advantage of it
- when creating new instance of ExpectedData we can now apply necessary filtering direcly on the dataset, rather than modifying the expected query itself,
- ExpectedData is now created for every query to make sure changes to properties on dbcontext are taken into account (e.g. TenantId),
- ExpectedData are cached to avoid big perf hit.

Also incorporated async GoW tests into the regular GoW test suite,

Fixes #21393
@maumar maumar mentioned this issue Oct 14, 2020
Merged
maumar added a commit that referenced this issue Oct 14, 2020
@maumar
Fix to #21393 - Query: Convert to AssertQuery in tests as much as pos…
c25101f 
…sible

added support for query filters to the AssertQuery test infra (using AssertFilteredQuery methods) and converted query filter tests to take advantage of it
- when creating new instance of ExpectedData we can now apply necessary filtering direcly on the dataset, rather than modifying the expected query itself,
- ExpectedData is now created for every query to make sure changes to properties on dbcontext are taken into account (e.g. TenantId),
- ExpectedData are cached to avoid big perf hit.

Also incorporated async GoW tests into the regular GoW test suite,

Fixes #21393
maumar added a commit that referenced this issue Oct 17, 2020
@maumar
Fix to #21393 - Query: Convert to AssertQuery in tests as much as pos…
727e090 
…sible

added support for query filters to the AssertQuery test infra (using AssertFilteredQuery methods) and converted query filter tests to take advantage of it
- when creating new instance of ExpectedData we can now apply necessary filtering direcly on the dataset, rather than modifying the expected query itself,
- ExpectedData is now created for every query to make sure changes to properties on dbcontext are taken into account (e.g. TenantId),
- ExpectedData are cached to avoid big perf hit.

Also incorporated async GoW tests into the regular GoW test suite,

Fixes #21393
maumar added a commit that referenced this issue Oct 17, 2020
@maumar
Fix to #21393 - Query: Convert to AssertQuery in tests as much as pos…
e878c08 
…sible

added support for query filters to the AssertQuery test infra (using AssertFilteredQuery methods) and converted query filter tests to take advantage of it
- when creating new instance of ExpectedData we can now apply necessary filtering direcly on the dataset, rather than modifying the expected query itself,
- ExpectedData is now created for every query to make sure changes to properties on dbcontext are taken into account (e.g. TenantId),
- ExpectedData are cached to avoid big perf hit.

Also incorporated async GoW tests into the regular GoW test suite,

Fixes #21393
maumar added a commit that referenced this issue Oct 19, 2020
@maumar
Fix to #21393 - Query: Convert to AssertQuery in tests as much as pos…
1bb52e7 
…sible

added support for query filters to the AssertQuery test infra (using AssertFilteredQuery methods) and converted query filter tests to take advantage of it
- when creating new instance of ExpectedData we can now apply necessary filtering direcly on the dataset, rather than modifying the expected query itself,
- ExpectedData is now created for every query to make sure changes to properties on dbcontext are taken into account (e.g. TenantId),
- ExpectedData are cached to avoid big perf hit.

Also incorporated async GoW tests into the regular GoW test suite,

Fixes #21393
maumar added a commit that referenced this issue Oct 19, 2020
@maumar
Fix to #21393 - Query: Convert to AssertQuery in tests as much as pos…
7401b7e 
…sible

added support for query filters to the AssertQuery test infra (using AssertFilteredQuery methods) and converted query filter tests to take advantage of it
- when creating new instance of ExpectedData we can now apply necessary filtering direcly on the dataset, rather than modifying the expected query itself,
- ExpectedData is now created for every query to make sure changes to properties on dbcontext are taken into account (e.g. TenantId),
- ExpectedData are cached to avoid big perf hit.

Also incorporated async GoW tests into the regular GoW test suite,

Fixes #21393
maumar added a commit that referenced this issue Oct 19, 2020
@maumar
Fix to #21393 - Query: Convert to AssertQuery in tests as much as pos…
46a746e 
…sible

added support for query filters to the AssertQuery test infra (using AssertFilteredQuery methods) and converted query filter tests to take advantage of it
- when creating new instance of ExpectedData we can now apply necessary filtering direcly on the dataset, rather than modifying the expected query itself,
- ExpectedData is now created for every query to make sure changes to properties on dbcontext are taken into account (e.g. TenantId),
- ExpectedData are cached to avoid big perf hit.

Also incorporated async GoW tests into the regular GoW test suite,

Fixes #21393
@maumar maumar closed this as completed in 58bcdd5 Oct 20, 2020
@ajcvickers ajcvickers modified the milestones: MQ, 6.0.0 Nov 25, 2020
@ajcvickers ajcvickers removed this from the 6.0.0 milestone Jan 27, 2021
@ajcvickers ajcvickers added this to the 6.0.0-preview1 milestone Jan 27, 2021
@ajcvickers ajcvickers modified the milestones: 6.0.0-preview1, 6.0.0 Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maumar maumar

Labels
area-query area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
6.0.0
4 participants
@ajcvickers @smitpatel @maumar @AndriySvyryd