Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove QueryFailed #22508

Closed
smitpatel opened this issue Sep 11, 2020 · 0 comments · Fixed by #23382
Closed

Remove QueryFailed #22508

smitpatel opened this issue Sep 11, 2020 · 0 comments · Fixed by #23382
Assignees
@smitpatel
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Milestone
6.0.0

Comments

@smitpatel
Copy link
Contributor

Potentially replace with UnhandledExpressionInVisitor.
@smitpatel smitpatel self-assigned this Sep 11, 2020
@ajcvickers ajcvickers added this to the MQ milestone Sep 14, 2020
smitpatel added a commit that referenced this issue Nov 18, 2020
@smitpatel
Remove QueryFailed
0d9a638 
Mainly error in projection binding expression visitor, when we have an unknown extension expression which is hit when client evaluating, (non-client eval we wouldn't reach this code).
Translation failure seems most appropriate error.
Returning NoTranslationExpression will actually provide lesser value in what failed exactly.

Cosmos has a lot of places where it used but those are supposed to invariants and shouldn't exist after Cosmos Query pipeline is updated.

Resolves #22508
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Nov 18, 2020
@smitpatel smitpatel mentioned this issue Nov 18, 2020
Merged
@ghost ghost closed this as completed in #23382 Nov 18, 2020
ghost pushed a commit that referenced this issue Nov 18, 2020
@smitpatel
Remove QueryFailed (#23382)
4dc48f3 
Mainly error in projection binding expression visitor, when we have an unknown extension expression which is hit when client evaluating, (non-client eval we wouldn't reach this code).
Translation failure seems most appropriate error.
Returning NoTranslationExpression will actually provide lesser value in what failed exactly.

Cosmos has a lot of places where it used but those are supposed to invariants and shouldn't exist after Cosmos Query pipeline is updated.

Resolves #22508
@ajcvickers ajcvickers modified the milestones: MQ, 6.0.0 Nov 25, 2020
@ajcvickers ajcvickers modified the milestones: 6.0.0, 6.0.0-preview1 Jan 27, 2021
@ajcvickers ajcvickers modified the milestones: 6.0.0-preview1, 6.0.0 Nov 8, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Remove QueryFailed dotnet/efcore
2 participants
@ajcvickers @smitpatel