Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support change tracking and lazy-loading proxies for complex types #31634

Closed
Tracked by #31238
ajcvickers opened this issue Sep 5, 2023 · 3 comments · Fixed by #31833
Closed
Tracked by #31238

Support change tracking and lazy-loading proxies for complex types #31634

ajcvickers opened this issue Sep 5, 2023 · 3 comments · Fixed by #31833
Labels
area-proxies closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone

Comments

@ajcvickers
Copy link
Contributor

No description provided.

@ajcvickers
Copy link
Contributor Author

See #31460 (review)

@cpa-level-it
Copy link

Is it correct that without this it'll not be possible to use complex types with UseLazyLoadingProxies ?

Using both right now I have the following issue when I do a Find on a DbSet.

The foreach throws a System.NotImplementedException: 'The method or operation is not implemented.' exception in EntityMaterializerSource.cs

private InstantiationBinding ModifyBindings(ITypeBase structuralType, InstantiationBinding binding)
{
	InstantiationBindingInterceptionData interceptionData = new InstantiationBindingInterceptionData(structuralType);
	foreach (IInstantiationBindingInterceptor bindingInterceptor in _bindingInterceptors)
	{
		binding = bindingInterceptor.ModifyBinding(interceptionData, binding);
	}
	return binding;
}

Without the call to UseLazyLoadingProxies the Find correctly returns the value.

Will this be addressed before the release of the 8.0 version ?

Thanks

@oleg-varlamov
Copy link

We had the same problem - it is impossible to use complex properties if UseLazyLoadingProxies is used in the project. Unfortunately, without fixing this problem, we cannot move to using complex properties.

@ajcvickers ajcvickers self-assigned this Sep 21, 2023
@ajcvickers ajcvickers added this to the 8.0.0 milestone Sep 21, 2023
ajcvickers added a commit that referenced this issue Sep 22, 2023
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Sep 22, 2023
@ajcvickers ajcvickers removed their assignment Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-proxies closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants