Fix issue https://github.com/dotnet/efcore/issues/21844 #21846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
AndriySvyryd
reviewed
Aug 1, 2020
smitpatel
reviewed
Aug 4, 2020
smitpatel
reviewed
Aug 4, 2020
smitpatel
reviewed
Aug 4, 2020
smitpatel
reviewed
Aug 4, 2020
smitpatel
reviewed
Aug 4, 2020
smitpatel
reviewed
Aug 4, 2020
|
All of the suggested changes are complete. I forced a revert and made the changes through a new check-in on the main branch. I have resolved-conversation on all of the changes to mark them as complete. |
|
@mikewodarczyk - There are still changes to add Records.Tests which needs to be removed. |
…h no names Resolves dotnet#21844
Update the test
smitpatel
approved these changes
Aug 5, 2020
|
@mikewodarczyk - Thank you for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EFCore now skips constructors generated with c#9 that contain parameters with no names.
The nameless constructor parameters were throwing null reference exceptions when
EFCore was trying to modify the strings to the various conventions for matching
properties like pascal-case, camel-case, m_, etc.