-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IConventionEntityTypeBuilder.HasSkipNavigation that takes an inverse #21850
Conversation
Hello @AndriySvyryd! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
[NotNull] EntityType targetEntityType, | ||
MemberIdentity inverseNavigation, | ||
ConfigurationSource configurationSource, | ||
bool? collections = null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can collection behavior of both skip navigation be different?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also collections vs collection in other methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. I think that would be less likely, so it would be ok to make two calls in that case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also collections vs collection in other methods
What do you mean? Other methods only have one navigation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bit odd, that method name is singular, takes 2 member identity and plural parameter. It will show up in API review!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bit odd, that method name is singular, takes 2 member identity and plural parameter. It will show up in API review!
It only create one navigation on this entity type and that's what it returns
Fixes #21486