Schrödinger's Cat #22123
Merged
Schrödinger's Cat #22123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let A be the set of properties which are not sharing column with any principal. B be the subset of A where property is required. C be subset of A where property is optional. (hence A = B + C) The necessary condition for materialization without anything else be C1 - all required properties (excluding PK) must have a value (with or without sharing). - If A is empty, then C1 will be sufficient condition as it will be required dependent. - If B is non-empty, then C1 will cover those properties and be sufficient condition. - If B is empty and then C is non-empty, then materialize if there is at least 1 non-null value in C along with C1 being true. - Otherwise null. If there are no required properties other than PK (essentially C1 does not exist). B is by definition empty. - If A is empty then always materialize. - If A is non-empty implies C is non-empty, then materialize if there is at least 1 non-null value in C. Resolves #22054
src/EFCore.Relational/Query/RelationalEntityShaperExpression.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Query/RelationalEntityShaperExpression.cs
Outdated
Show resolved
Hide resolved
AndriySvyryd
approved these changes
Aug 19, 2020
Co-authored-by: Andriy Svyryd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Query: New set of conditions to materialize optional dependents
Let A be the set of properties which are not sharing column with any principal.
B be the subset of A where property is required.
C be subset of A where property is optional. (hence A = B + C)
The necessary condition for materialization without anything else be C1 - all required properties (excluding PK) must have a value (with or without sharing).
If there are no required properties other than PK (essentially C1 does not exist). B is by definition empty.
Resolves #22054