[Cosmos] Translate __jObject to Access Root #22143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ject property.
|
@TheFanatr You need to add at least one test the fails without this change |
|
@AndriySvyryd Done. |
|
Is there a reason the tests are failing on |
|
It's failing because it's not using ConditionalTheory, so the test runs even if there's no Cosmos emulator available. |
… is provided, and update ReloadTest to verify that __jObject is updated after reloads.
Co-authored-by: Andriy Svyryd <[email protected]>
TheFanatr
changed the title
TheFanatr
changed the title
AndriySvyryd
approved these changes
Aug 22, 2020
|
Thanks for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so that the EFCore CosmosDB provider translates the
__jObjectproperty on all entities even though it is non-persisted, in order to allowawait someContext.ReloadAsync()to not throw. This is discussed in #18710.In order to allow the
__jObjectproperty to have an updated value after reload,KeyAccessExpressionwas changed so that it translates toAccessExpressioninstead ofAccessExpression[Name] ifNameisnullor of size 0, so that the translated__jObjectproperty value in the JSON is given the document as it's value. This will only cause problems if there are other cases where non-persisted properties need to be translated toc[""], which wouldn't be the case even with #17670 fixed.Fixes #18710