Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-run fk discovery convention when skip navigation changes #22153

Merged
1 commit merged into from
Aug 24, 2020
Merged

Conversation

AndriySvyryd
Copy link
Member

Unify base FK property name logic
Unify implicit property logic

Fixes #22128

@AndriySvyryd AndriySvyryd requested a review from smitpatel August 20, 2020 19:52
@AndriySvyryd
Copy link
Member Author

@dotnet/efteam New public API:

  • ForeignKeyPropertyDiscoveryConvention.GetPropertyBaseName()
  • IConventionProperty.IsImplicitlyCreated()

@ghost
Copy link

ghost commented Aug 20, 2020

Hello @AndriySvyryd!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@AndriySvyryd AndriySvyryd force-pushed the Issue22128 branch 3 times, most recently from 6211c92 to 95a2edd Compare August 20, 2020 21:20
Unify base FK property name logic
Unify implicit property logic

Fixes #22128
@ghost ghost merged commit db0597c into release/5.0 Aug 24, 2020
@ghost ghost deleted the Issue22128 branch August 24, 2020 18:48
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Foreign key convention generates different names when explicit join type is used
2 participants