Cache derived types used in DerivedTypeDiscoveryConvention. #22314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet/efteam Obsoleted API:
New API:
|
AndriySvyryd
force-pushed
the
Issue20135
branch
2 times, most recently
from
4c98a14 to
8ec3fb2
Compare
smitpatel
reviewed
Aug 30, 2020
smitpatel
reviewed
Aug 30, 2020
smitpatel
reviewed
Aug 30, 2020
smitpatel
reviewed
Aug 30, 2020
src/EFCore/Metadata/Conventions/NavigationAttributeConventionBase.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Aug 30, 2020
src/EFCore/Metadata/Conventions/NavigationAttributeConventionBase.cs
Outdated
Show resolved
Hide resolved
smitpatel
approved these changes
Aug 30, 2020
AndriySvyryd
force-pushed
the
Issue20135
branch
2 times, most recently
from
48c324a to
d388067
Compare
|
@Pilchie For RC1 |
smitpatel
reviewed
Aug 30, 2020
src/EFCore/Metadata/Conventions/NavigationAttributeConventionBase.cs
Outdated
Show resolved
Hide resolved
|
Approved for RC1. |
Merge BaseTypeDiscoveryConvention with DerivedTypeDiscoveryConvention. Make sure that base type is reset when it becomes owned. Remove entries from the ambiguous inverses as soon as the navigation or declarung type is ignored.
AndriySvyryd
force-pushed
the
Issue20135
branch
from
d388067 to
12a9a30
Compare
|
Hello @AndriySvyryd! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge BaseTypeDiscoveryConvention with DerivedTypeDiscoveryConvention.
Make sure that base type is reset when it becomes owned.
Remove entries from the ambiguous inverses as soon as the navigation or declaring type is ignored.