Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nullability check to In-Memory Database #23094

Merged
merged 4 commits into from
Nov 9, 2020
Merged

Add nullability check to In-Memory Database #23094

merged 4 commits into from
Nov 9, 2020

Conversation

fagnercarvalho
Copy link
Contributor

Fixes #10613

@dnfadmin
Copy link

dnfadmin commented Oct 25, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

@ajcvickers ajcvickers self-assigned this Oct 26, 2020
ajcvickers
ajcvickers approved these changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@ajcvickers ajcvickers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Sorry for being so slow to review it.

@ajcvickers
Copy link
Contributor

@smitpatel @AndriySvyryd This looks good to me, but I'm not great at noticing places where style, etc. might be wrong. You guys are good at that. :-) Do you want to give it a quick scan?

@ajcvickers ajcvickers merged commit fbc43f6 into dotnet:main Nov 9, 2020
@ajcvickers
Copy link
Contributor

@fagnercarvalho Thanks for the contribution!

@fagnercarvalho fagnercarvalho deleted the NullabilityCheckInMemory branch November 9, 2020 20:01
@ajcvickers ajcvickers mentioned this pull request Nov 12, 2020
Closed
@devlear
Copy link

devlear commented Dec 8, 2021

I'm not sure if you would like a separate issue created for this, but the changed entity will still be in the ChangeTracker after the DbUpdateException is thrown.

@AndriySvyryd
Copy link
Member

@devlear That's by design. If any exception happens during SaveChanges EF tries to revert to the state before SaveChanges was called.

@poke poke mentioned this pull request Apr 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajcvickers ajcvickers ajcvickers approved these changes

@smitpatel smitpatel smitpatel left review comments

Assignees

@ajcvickers ajcvickers

Labels
community-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate requiredness (nullability) in the in-memory database
6 participants
@fagnercarvalho @dnfadmin @ajcvickers @devlear @AndriySvyryd @smitpatel