Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First nullability work on metadata #23133

Merged
2 commits merged into from
Oct 29, 2020
Merged

First nullability work on metadata #23133

2 commits merged into from
Oct 29, 2020

Conversation

roji
Copy link
Member

@roji roji commented Oct 29, 2020

Annotates Annotatable (haha), EntityType and related types.

No particular difficulties encountered, this was quite straightforward. A couple notes:

  • I've annotated mutating methods (e.g. EntityType.SetPrimaryKey) to return nullable, because they return the results of conventions which could return null. Is this correct?
  • I know we don't like TODO comments, but in some places I've left special TODO-NULLABLE for stuff to check/improve (this was the pattern used in the runtime repo).

@roji
First nullability work on metadata
04e02d8 
Annotatable, EntityType and related types
@roji roji requested a review from AndriySvyryd October 29, 2020 13:34
roji
roji commented Oct 29, 2020
View reviewed changes
@roji roji mentioned this pull request Oct 29, 2020
Merged
@roji roji requested a review from AndriySvyryd October 29, 2020 19:19
@ghost
Copy link

ghost commented Oct 29, 2020

Hello @roji!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 7c5c1fc into dotnet:main Oct 29, 2020
@roji roji linked an issue Oct 30, 2020 that may be closed by this pull request
Annotate EF Core for nullable reference types #19007
Closed
23 tasks
@ajcvickers ajcvickers mentioned this pull request Nov 5, 2020
Closed
@roji roji deleted the MetadataNullability branch January 13, 2021 19:46
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

Assignees
No one assigned
Labels
auto-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Annotate EF Core for nullable reference types
2 participants
@roji @AndriySvyryd