Microsoft.Data.Sqlite: Enable nullable reference types #23549

bricelam · 2020-12-01T21:41:08Z

Part of #19007

Also updates the behavior of SqliteDataReader.GetChars when buffer is null and GetBytes when dataOffset is specified.

src/Microsoft.Data.Sqlite.Core/SqliteCommand.cs

src/Microsoft.Data.Sqlite.Core/SqliteConnectionStringBuilder.cs

src/Microsoft.Data.Sqlite.Core/SqliteDataReader.cs

src/Microsoft.Data.Sqlite.Core/SqliteValueReader.cs

src/Microsoft.Data.Sqlite.Core/SqliteConnection.CreateAggregate.cs

src/Microsoft.Data.Sqlite.Core/Extensions/SqliteConnectionExtensions.cs

src/Microsoft.Data.Sqlite.Core/Microsoft.Data.Sqlite.Core.csproj

src/Microsoft.Data.Sqlite.Core/SqliteBlob.cs

src/Microsoft.Data.Sqlite.Core/SqliteCommand.cs

roji

Great to see this...

src/Microsoft.Data.Sqlite.Core/Extensions/SqliteConnectionExtensions.cs

src/Microsoft.Data.Sqlite.Core/SqliteConnection.CreateAggregate.cs

src/Microsoft.Data.Sqlite.Core/SqliteConnection.CreateFunction.cs

src/Microsoft.Data.Sqlite.Core/SqliteConnection.CreateAggregate.cs

src/Microsoft.Data.Sqlite.Core/SqliteConnection.cs

src/Microsoft.Data.Sqlite.Core/SqliteConnectionStringBuilder.cs

src/Microsoft.Data.Sqlite.Core/SqliteDataReader.cs

src/Microsoft.Data.Sqlite.Core/SqliteTransaction.cs

src/Microsoft.Data.Sqlite.Core/SqliteConnectionStringBuilder.cs

bricelam · 2020-12-07T22:58:35Z

@roji This should be good to go if you want to give it a final review.

src/Microsoft.Data.Sqlite.Core/SqliteConnection.CreateAggregate.cs

src/Microsoft.Data.Sqlite.Core/SqliteConnection.cs

src/Microsoft.Data.Sqlite.Core/SqliteDataRecord.cs

bricelam requested a review from a team December 1, 2020 21:41

bricelam commented Dec 1, 2020

View reviewed changes

This comment has been minimized.

Sign in to view

bricelam commented Dec 2, 2020

View reviewed changes

src/Microsoft.Data.Sqlite.Core/SqliteConnection.CreateAggregate.cs Outdated Show resolved Hide resolved