Respond to PR feedback

dotnet · Jun 29, 2016 · 50e1a92 · 50e1a92
1 parent 9dc976b
commit 50e1a92
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 0 deletions.
diff --git a/src/Microsoft.Extensions.CommandLineUtils/CommandLine/CommandLineApplication.cs b/src/Microsoft.Extensions.CommandLineUtils/CommandLine/CommandLineApplication.cs
@@ -67,6 +67,7 @@ public CommandLineApplication Command(string name, Action<CommandLineApplication
 
         public CommandOption Option(string template, string description, CommandOptionType optionType)
             => Option(template, description, optionType, _ => { }, inherited: false);
+
         public CommandOption Option(string template, string description, CommandOptionType optionType, bool inherited)
             => Option(template, description, optionType, _ => { }, inherited);
 

diff --git a/test/Microsoft.Extensions.CommandLineUtils.Tests/CommandLineApplicationTests.cs b/test/Microsoft.Extensions.CommandLineUtils.Tests/CommandLineApplicationTests.cs
@@ -433,6 +433,29 @@ public void NestedOptionConflictThrows()
             Assert.Throws<InvalidOperationException>(() => app.Execute("subcmd", "-a", "b"));
         }
 
+        [Fact]
+        public void OptionsWithSameName()
+        {
+            var app = new CommandLineApplication();
+            var top = app.Option("-a|--always", "Top-level", CommandOptionType.SingleValue, inherited: false);
+            CommandOption nested = null;
+            app.Command("subcmd", c =>
+            {
+                nested = c.Option("-a|--ask", "Nested", CommandOptionType.SingleValue);
+            });
+
+            app.Execute("-a", "top");
+            Assert.Equal("top", top.Value());
+            Assert.Null(nested.Value());
+
+            top.Values.Clear();
+
+            app.Execute("subcmd", "-a", "nested");
+            Assert.Null(top.Value());
+            Assert.Equal("nested", nested.Value());
+        }
+
+
         [Fact]
         public void NestedInheritedOptions()
         {