Suggest a function to implement if no abstract method matches

[forki]

while working on #1229 I found this would be useful:

[isaacabraham]

Link to #1232

[forki]

One of the existing tests showed an interesting case. Here we don't have an implementation slot since the method is already implemented. I tried to improve the message for this case as well:

[forki]

I think this one is ready for review

[KevinRansom]

How about a small change to the Message:

The type Foo contains the member 'MyX' but it is not a virtual or abstract method that is available to override or implement.
Available methods to override or implement:
   Equals
   ...

[forki]

@KevinRansom I'd like to keep the "Maybe you want" part consistent. This allows emacs users to grep and use this as poor man's IntelliSense.
That said: we should probably improve the concrete wording in that part.

[KevinRansom]

@forki "Maybe you want" is usually a question rather than a statement and so there should be a question mark there somewhere. That is why I think "Available methods to override or implement:" is preferable.

[forki]

Yep I agree. Current formulation is suboptimal. But I'd like to have the
same sentence for all of these suggestions. So I hope we can find one that
is better than the current and still works everywhere. (as said above this
might allow some tools to actually make sense out of this)
On Jun 24, 2016 4:53 PM, "Kevin Ransom (msft)" [email protected]
wrote:

@forki https://github.com/forki "Maybe you want" is usually a question
rather than a statement and so there should be a question mark there
somewhere. That is why I think "Available methods to override or
implement:" is preferable.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1230 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AADgNJVVXAWGIbDCkz113cXF7uJ7Ntmlks5qO-91gaJpZM4IqjoM
.

[TeaDrivenDev]

"You may want"?

[dsyme]

Thanks again @forki and @isaacabraham