Show better error when using ref cell instead of not #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
forki
commented
Jun 22, 2016
forki
commented
81 tasks
forki
force-pushed
the
refcell
branch
3 times, most recently
from
0764adc to
94e054a
Compare
|
Well that looks good :) |
| | ContextInfo.TupleInRecordFields -> | ||
| os.Append(ErrorFromAddingTypeEquation1E().Format t2 t1 tpcs) |> ignore | ||
| os.Append(System.Environment.NewLine + FSComp.SR.commaInsteadOfSemicolonInRecord()) |> ignore | ||
| | _ when t2 = "bool" && t1.EndsWith " ref" -> |
There was a problem hiding this comment.
A bit of a hacky way to get this condition, but I suppose it's good enough :) It's hard to imagine it no working.
There was a problem hiding this comment.
yeah tried a couple of things, but this was still the "best"
forki
force-pushed
the
refcell
branch
3 times, most recently
from
103a6d6 to
7eb2b28
Compare
forki
changed the title
|
ready for inital review |
|
Looks good to me. @forki Thanks for taking care of this. Kevin |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.