MaybeNull wrapper round nullness syntax removed and refactored for src/fsi/console.fs #18201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le null syntax done and MaybeNull" wrapper removed.
✅ No release notes required |
progressive-galib
changed the title
T-Gro
approved these changes
Jan 6, 2025
|
Thank you for your first contribution! |
psfinaki
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
Thanks @progressive-galib. Code cleanup is important so looking forward to further contributions here :)
This is ready to go, now it only needs your @dotnet-policy-service agree here (CLA approval is only needed for the first contribution).
|
@dotnet-policy-service agree |
This was referenced Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related: #18061 (partially addresses)