Bugfix:: Add missing codegen for mapping of overlapped struct DU fields and read it in fslib reflection #18274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y-array-for-non-first-cases-of-struct-unions-with-shared-fields
Co-authored-by: Brian Rourke Boll <[email protected]>
…y-array-for-non-first-cases-of-struct-unions-with-shared-fields
T-Gro
commented
Feb 3, 2025
T-Gro
commented
Feb 3, 2025
0101
approved these changes
Feb 3, 2025
T-Gro
commented
Feb 3, 2025
…y-array-for-non-first-cases-of-struct-unions-with-shared-fields
❗ Release notes required
Warning No PR link found in some release notes, please consider adding it.
|
abonie
approved these changes
Feb 4, 2025
T-Gro
deleted the
18121-fsharpvaluegetunionfields-returns-empty-array-for-non-first-cases-of-struct-unions-with-shared-fields
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18121
To apply this fix, BOTH constellations will be needed:
An intermediáte library can be compiled against a lower fslib if the application uses fresh one at runtime.
Attributes coming for structs with field reuse compiled after this change WILL fail with
Multiple CompilationMappingAttributes, expected at most oneif they are consumed by reflection with an older FSharp.Core version.Explicit exception is thrown in order to prevent incorrect results (=this is what the existing bug causes).