Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate .Using and |null in builders #18292

Merged
merged 14 commits into from
Feb 10, 2025
Merged

Consolidate .Using and |null in builders #18292

merged 14 commits into from
Feb 10, 2025

Conversation

T-Gro
Copy link
Member

@T-Gro T-Gro commented Feb 4, 2025

This builds on top of previous PRs that fixed bugs related to subsumption and use.
This now consolidates disposables within the codebase and also annotates Builder types that come with an .Using method.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/FSharp.Core docs/release-notes/.FSharp.Core/9.0.300.md
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.300.md

@T-Gro T-Gro marked this pull request as ready for review February 6, 2025 13:27
@T-Gro T-Gro requested a review from a team as a code owner February 6, 2025 13:28
@T-Gro T-Gro merged commit b64ea2b into main Feb 10, 2025
33 checks passed
@T-Gro T-Gro deleted the adjust-activity-module-nullness-changes branch February 10, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0101 0101 0101 approved these changes

@psfinaki psfinaki psfinaki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@T-Gro @0101 @psfinaki