Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only build the Microsoft.FSharp.Compiler.sln solution in the VMR #18299

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

jkoritzinsky
Copy link
Member

Description

The VMR needs to consume the Microsoft.FSharp.Compiler package (which has the other packages embedded) in all scenarios, not just SourceBuild scenarios

Fixes dotnet/source-build#4799

Checklist

  • Test cases added

  • Performance benchmarks added in case of performance changes

  • Release notes entry updated:

    Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

    Release notes files:

    • If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
    • If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/release-notes/.Language/preview.md
    • If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.

    Information about the release notes entries format can be found in the documentation.
    Example:

    If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

@jkoritzinsky jkoritzinsky added Area-Infrastructure NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes labels Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@jkoritzinsky jkoritzinsky marked this pull request as ready for review February 8, 2025 00:44
@jkoritzinsky jkoritzinsky requested a review from a team as a code owner February 8, 2025 00:44
@jkoritzinsky jkoritzinsky merged commit ad29712 into dotnet:main Feb 8, 2025
35 checks passed
@jkoritzinsky jkoritzinsky deleted the vmr-fix branch February 8, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[UB] fsharp does not produce Microsoft.FSharp.Compiler artifact on Linux
3 participants