Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .NET #18333

Merged
merged 4 commits into from
Feb 24, 2025
Merged

Update .NET #18333

merged 4 commits into from
Feb 24, 2025

Conversation

vzarytovskii
Copy link
Member

@vzarytovskii vzarytovskii commented Feb 21, 2025

Update to 9.0.200 and sync between devcontainer, globaljson and fslib package version used by JB folks

@vzarytovskii vzarytovskii requested a review from a team as a code owner February 21, 2025 18:31
Copy link
Contributor

✅ No release notes required

@vzarytovskii
Copy link
Member Author

@Martin521 this should fix the devcontainer issue

@vzarytovskii vzarytovskii enabled auto-merge (squash) February 21, 2025 18:50
@Martin521
Copy link
Contributor

@Martin521 this should fix the devcontainer issue

Thanks!

@Martin521
Copy link
Contributor

With these changes, script build and test works fine for me locally.
If, however, I use dotnet build FCS.sln, I get 5 nullness related failures in ComponentTests.
If I set FSHARPCORE_USE_PACKAGE to false, I get a build error:
src/Compiler/TypedTree/TypeProviders.fs(1161,147): error FS0039: The value or constructor 'withNull' is not defined. Maybe you want one of the following: withEnd isNull

@vzarytovskii
Copy link
Member Author

With these changes, script build and test works fine for me locally.

If, however, I use dotnet build FCS.sln, I get 5 nullness related failures in ComponentTests.

If I set FSHARPCORE_USE_PACKAGE to false, I get a build error:

src/Compiler/TypedTree/TypeProviders.fs(1161,147): error FS0039: The value or constructor 'withNull' is not defined. Maybe you want one of the following: withEnd isNull

Not sure what's wrong there. Someone must've forgotten to change something when changed some nullness related code.

@vzarytovskii
Copy link
Member Author

With these changes, script build and test works fine for me locally.

If, however, I use dotnet build FCS.sln, I get 5 nullness related failures in ComponentTests.

If I set FSHARPCORE_USE_PACKAGE to false, I get a build error:

src/Compiler/TypedTree/TypeProviders.fs(1161,147): error FS0039: The value or constructor 'withNull' is not defined. Maybe you want one of the following: withEnd isNull

Just to note: build scripts is the only supported and tested way of building compiler, plain builds may be overlooked since it was pretty much only me who was using those.

@Martin521
Copy link
Contributor

@T-Gro Will plain builds still be supported?

@vzarytovskii vzarytovskii merged commit ee2a501 into main Feb 24, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants