Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name-mangling of provided types #203

Closed
wants to merge 6 commits into from
Closed

Conversation

forki
Copy link
Contributor

@forki forki commented Feb 3, 2015

This is similar to #101 but also fixes the mangling of the type names.
It won't generate the trailing comma - see cf897f5

@latkin
Copy link
Contributor

latkin commented Feb 3, 2015

This seems like a good change to me. Main thing I'd be worried about is if there are any hidden dependencies elsewhere (other parts of the codebase, or exposed in previous versions) on the old mangled format.

@forki
Copy link
Contributor Author

forki commented Feb 3, 2015

other parts of the codebase

VFPT says it's the only place. It seems it's only used for TPs.

exposed in previous versions
yep that's the reason I didn't put it in the first PR.

But I think the use case was broken in older versions, so even compiled code wouldn't work. But since we fix both (mangle and demangle) maybe even older code might magicaly work now. Or not ;-)

@dsyme
Copy link
Contributor

dsyme commented Feb 3, 2015

The change looks good, but why do you mention #101?

@forki
Copy link
Contributor Author

forki commented Feb 3, 2015

I meant #102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants