Fix #370 - implement proper ER-mode comparison for floating point types #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I merged you changes into #372 and our sorting tests become green ;-) |
|
👍 This is fantastic! I had no clue how to get around NaNs when doing the SortBy, turns out I was only about 2 levels of abstractions away from enlightenment. |
| elif (# "ceq" x y : bool #) then (0) | ||
| elif (# "ceq" x x : bool #) then (1) | ||
| elif (# "ceq" y y : bool #) then (-1) | ||
| else (0) |
There was a problem hiding this comment.
Reordering the nan comparisons we can eliminate a branch
when 'T : float = if (# "clt" x y : bool #) then (-1)
elif (# "cgt" x y : bool #) then (1)
elif (# "ceq" x y : bool #) then (0)
elif (# "ceq" y y : bool #) then (-1)
else (# "ceq" x x : bool #)
It's similar to what was done here previously, but doesn't avoid any extra IL calls and is arguably less clear
There was a problem hiding this comment.
Nice! I think you mean (# "ceq" x x : int #) on the last line (return the ceq result as int value 1 or 0, not bool value)
There was a problem hiding this comment.
Yes, that's what I meant 😊
|
Nice work - great fix, great testing. |
|
Looks great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #370. Root cause was that
GenericComparisonFastdid not have an accurate implementation of ER-mode floating point comparison. Testing showed that nonstructuralcomparehad the same issue.The added
compretests here should cover the code well enough, but I'm also planning to add some actual floating-point sorting tests to the core unittests.