Uniform TryGetValue usage #6598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forki
approved these changes
Apr 21, 2019
src/absil/ilwrite.fs
Outdated
| let ok = tbl.dict.TryGetValue(x, &res) | ||
| if ok then res | ||
| else tbl.AddSharedEntry x | ||
| match tbl.dict.TryGetValue(x) with |
KevinRansom
reviewed
Apr 22, 2019
src/utils/HashMultiMap.fs
Outdated
| let ok = firstEntries.TryGetValue(y,&res) | ||
| if ok then Some(res) else None | ||
| match firstEntries.TryGetValue y with | ||
| | true, res -> Some(res) |
There was a problem hiding this comment.
Do we need the brackets here?
There was a problem hiding this comment.
@KevinRansom That's how it was, fixed now.
There was a problem hiding this comment.
@ncave, yeah I get it, it's the worst part of cleanup PR's. You opt in to fixing all of the rubbish that was there before :-)
KevinRansom
approved these changes
Apr 22, 2019
|
Thanks for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making
TryGetValueusage more uniform.