Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VSConfig file #6622

Merged
merged 2 commits into from
Apr 24, 2019
Merged

Add VSConfig file #6622

merged 2 commits into from
Apr 24, 2019

Conversation

cartermp
Copy link
Contributor

Fixes #6581

This should allow someone to open VisualFSharp.sln in VS without knowing exactly what to install and be prompted by VS to install the correct components.

See this blog post for more info: https://devblogs.microsoft.com/setup/configure-visual-studio-across-your-organization-with-vsconfig/

@saul
Copy link
Contributor

saul commented Apr 23, 2019

This is a great step for first time contributors. Is this as minimal as possible? I see e.g. TypeScript and Docker in there, chose (and any others) be removed if they’re not necessary?

@cartermp
Copy link
Contributor Author

Mea culpa, included some other stuff I installed.

"Microsoft.Net.ComponentGroup.DevelopmentPrerequisites",
"Microsoft.Component.MSBuild",
"Microsoft.VisualStudio.Component.TextTemplating",
"Microsoft.VisualStudio.Component.SQL.CLR",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note - yes, this is technically required

"Microsoft.Net.Component.4.7.2.TargetingPack",
"Microsoft.Net.ComponentGroup.DevelopmentPrerequisites",
"Microsoft.Component.MSBuild",
"Microsoft.VisualStudio.Component.TextTemplating",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is technically required - legacy .NET projects take a dependency on this for the property pages

@cartermp cartermp closed this Apr 24, 2019
@cartermp cartermp reopened this Apr 24, 2019
@cartermp
Copy link
Contributor Author

Command failed to execute with exit code 1: C:\Users\VssAdministrator\.nuget\packages\StrawberryPerl64\5.22.2.1\Tools\perl\bin\perl.exe "D:\a\1\s\tests\fsharpqa\testenv\bin\runall.pl" -resultsroot "D:\a\1\s\artifacts\TestResults\Release" -results test-net40-fsharpqa-results.log -log test-net40-fsharpqa-errors.log -fail test-net40-fsharpqa-errors -cleanup:no -procs:2
System.Management.Automation.RuntimeException: Command failed to execute with exit code 1: C:\Users\VssAdministrator\.nuget\packages\StrawberryPerl64\5.22.2.1\Tools\perl\bin\perl.exe "D:\a\1\s\tests\fsharpqa\testenv\bin\runall.pl" -resultsroot "D:\a\1\s\artifacts\TestResults\Release" -results test-net40-fsharpqa-results.log -log test-net40-fsharpqa-errors.log -fail test-net40-fsharpqa-errors -cleanup:no -procs:2
at Exec-CommandCore, D:\a\1\s\eng\build-utils.ps1: line 50
at Exec-Console, D:\a\1\s\eng\build-utils.ps1: line 119
at <ScriptBlock>, D:\a\1\s\eng\Build.ps1: line 279

image

cc @brettfo @KevinRansom

@cartermp cartermp closed this Apr 24, 2019
@cartermp cartermp reopened this Apr 24, 2019
@cartermp
Copy link
Contributor Author

Yay flaky CI. Let's get this in before the machines get angry at me!

@cartermp cartermp requested review from brettfo and KevinRansom April 24, 2019 20:11
@KevinRansom KevinRansom merged commit 454764b into dotnet:master Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use a .vsconfig file
4 participants