Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PortableRid default for cross-build source-builds. #18854

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Fix PortableRid default for cross-build source-builds. #18854

merged 1 commit into from
Mar 5, 2024

Conversation

tmds
Copy link
Member

@tmds tmds commented Mar 4, 2024

@tmds tmds requested a review from a team as a code owner March 4, 2024 12:17
@ViktorHofer
Copy link
Member

@directhex PTAL

@tmds
Copy link
Member Author

tmds commented Mar 5, 2024

I've added this condition in #18658.

It was working until #18632 was merged where HostArchitecture now defaults to TargetArchitecture instead of BuildArchitecture.

With #18658, I had wrongly assumed HostArchitecture would refer to the architecture of the host building the VMR, and this PR is now fixing that by using BuildArchitecture instead.

@ViktorHofer ViktorHofer merged commit bdc894d into dotnet:main Mar 5, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmds @ViktorHofer