Bump to dotnet/android-tools/main@3debf8e0 #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: dotnet/android-tools@137ad81...3debf8e * dotnet/android-tools@3debf8e: [BaseTasks] Import Xamarin.Build.AsyncTask (#237) * dotnet/android-tools@9674590: Update pipeline and pipeline info in README.md (#239) * dotnet/android-tools@1c09dcc: Update README.md and build scripts (#238) * dotnet/android-tools@2606225: Bump to dotnet/msbuild@33de0b22 (#232) * dotnet/android-tools@555d509: Bump LibZipSharp and Xamarin.Build.AsyncTask (#236) * dotnet/android-tools@da2c33e: Force loc task pool image to windows (#234)
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jul 5, 2024
jonpryor
added a commit
to dotnet/android
that referenced
this pull request
Jul 8, 2024
Fixes: #9038 Changes: dotnet/java-interop@ccafbe6...7a058c0 * dotnet/java-interop@7a058c0e: [Java.Interop] Add `IJavaPeerable.JavaAs()` extension method (dotnet/java-interop#1234) * dotnet/java-interop@6f9defa5: Bump to dotnet/android-tools@3debf8e0 (dotnet/java-interop#1236) * dotnet/java-interop@6923fb89: [ci] Add dependabot branches to build triggers (dotnet/java-interop#1233) * dotnet/java-interop@573028f3: [ci] Use macOS 13 Ventura build agents (dotnet/java-interop#1235) dotnet/java-interop@7a058c0e adds a new `IJavaPeerable.JavaAs<T>()` extension method, to perform type casts which return `null` when the cast will not succeed instead of throwing an exception. Update `AndroidValueManager.CreatePeer()` to check for Java-side type compatibility (by way of `TypeManager.CreateInstance()`). Previously, this would not throw: var instance = … var r = instance.PeerReference; var wrap_instance = JniRuntime.CurrentRuntime.ValueManager.CreatePeer ( reference: ref r, options: JniObjectReferenceOptions.Copy, targetType: typeof (SomeInterfaceThatInstanceDoesNotImplement)); // `wrap_instance` is not null, `.CreatePeer()` does not throw wrap_instance.SomeMethod(); // will throw, due to a type mismatch. `AndroidValueManager.CreatePeer()` will now return `null` if the Java instance referenced by the `reference:` parameter is not convertible to `targetType`, as per [`JNIEnv::IsAssignableFrom()`][0]. [0]: https://docs.oracle.com/javase/8/docs/technotes/guides/jni/spec/functions.html#IsAssignableFrom
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: dotnet/android-tools@137ad81...3debf8e