[Localization] Using old translations for our MSBuild localization #11478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 7, 2021 10:43
spouliot
approved these changes
May 7, 2021
|
Now we are talking :) |
mandel-macaque
approved these changes
May 7, 2021
✅ [PR Build] Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) 🎉 All 107 tests passed 🎉Pipeline on Agent XAMBOT-1094.BigSur' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes the old translations we used in MSBuild and adds them to our new localization flow.
This will allow us to not drop translations for any customers until we get the localization strings back from the Loc team in the new OneLocBuild localization pipeline.
This also re-enables 2 of the MSBuild localization tests that I ignored in a previous PR.
I still cannot remove the ignores for any mtouch localization tests since we did not have those translations.
There are also 4 new languages added from OneLocBuild that do not have existing translations so I needed to keep one of the msbuild tests ignored.