Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xharness] Add ARM64 variations for macOS/.NET using both MonoVM and CoreCLR. #11516

Merged

Conversation

rolfbjarne
Copy link
Member

@rolfbjarne rolfbjarne commented May 12, 2021

The CoreCLR version gets to the exact same place for ARM64 as the x86_64 version (good!).

The MonoVM version crashes at launch with:

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   libsystem_platform.dylib      	0x0000000190fbf6c8 _platform_memset_pattern16 + 296
1   libcoreclr.dylib              	0x00000001035a49a0 mono_arch_create_sdb_trampoline + 76
2   libcoreclr.dylib              	0x000000010356b6ac mini_get_breakpoint_trampoline + 80
3   libcoreclr.dylib              	0x0000000103595908 mono_arch_init + 48
4   libcoreclr.dylib              	0x00000001034db268 mini_init + 580
5   libcoreclr.dylib              	0x000000010352eae8 mono_jit_init_version + 20
6   com.xamarin.monotouch-test    	0x0000000102ca0498 xamarin_bridge_initialize + 192 (monovm-bridge.m:84)
7   com.xamarin.monotouch-test    	0x0000000102ca5de8 xamarin_main + 1332 (monotouch-main.m:408)

This needs further investigation (the curious part is that this doesn't happen with the legacy Xamarin.Mac version).

This is due to: dotnet/runtime#52635

@rolfbjarne rolfbjarne added the not-notes-worthy Ignore for release notes label May 12, 2021
@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build] Tests passed on Build. ✅

Tests passed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

API Diff (from PR only) (no change)
Generator Diff (no change)

🎉 All 80 tests passed 🎉

Pipeline on Agent XAMBOT-1096.BigSur'
Merge 15051d1 into 82f8ca8

@spouliot
Copy link
Contributor

spouliot commented May 12, 2021

@mandel-macaque there's something wrong in the file check wrt tests enabled. If xharness is modified then we should run all (non device) tests.

monotouch-test (Succeeded; Ignored)
-Mac [dotnet] (Succeeded; Ignored)
+Debug (ARM64) [dotnet] (Ignored)
+Debug (CoreCLR) [dotnet] (Ignored)
+Debug (CoreCLR, ARM64) [dotnet] (Ignored)
+Debug [dotnet] (Succeeded)

^ hmm... maybe not (in this case) since they would not run properly yet (and the dotnet variation was run).

Still any change in xharness is an unknown (when the decision to run which tests is made) so all tests should be run.

@rolfbjarne rolfbjarne merged commit 913cbb6 into dotnet:main May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-notes-worthy Ignore for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants