Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show platform UI for alert/prompt in webviews #6963

Open
mattleibow opened this issue May 9, 2022 · 3 comments
Open

Show platform UI for alert/prompt in webviews #6963

mattleibow opened this issue May 9, 2022 · 3 comments

Comments

@mattleibow
Copy link
Member

Description

This probably should not happen and apps should not do this, but we added a feature in Xamarin.Forms that appears to have value to some people: https://docs.microsoft.com/en-us/xamarin/xamarin-forms/platform/windows/webview-javascript-alert

This current feature only talks about Windows, but I see the Blazor team has done things for iOS. For this reason, we need to clarify what we want to allow and how we want to handle it. If apps are not supposed to use alert/prompt, then why is blazor using specific code - and why not all the platforms? If we want to use this, then we need to make sure it works in all webviews.

Related: windows prompts look bad: #6961

Public API Changes

None (maybe)

Intended Use-Case

Show a platform UI for web view alerts and prompts.

@mattleibow mattleibow added this to the 6.0.300-servicing milestone May 9, 2022
@Eilon Eilon added the area-controls-webview WebView label May 9, 2022
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 9, 2022
@javiercn
Copy link
Member

@mattleibow I'm not aware that we have any specific code for dealing with alerts and things like that in Blazor. (Other than maybe a setting to enable them).

If this setting is off by default and we enabled it in the webview configuration, it is likely an artifact of wanting to do something with the samples in the repo.

That said, unfortunately alert and other types of dialogs are not something we can neglect as they are (sadly) part of the feature set of the platform and some third-party libraries might be depending on it.

We should figure out what we need to do to make sure that if they are enabled, they look correct across the supported platforms.

@Redth Redth modified the milestones: 6.0-servicing, Backlog Aug 30, 2022
@ghost
Copy link

ghost commented Aug 30, 2022

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@jsuarezruiz jsuarezruiz added the t/enhancement ☀️ New feature or request label Oct 20, 2022
@jsuarezruiz
Copy link
Contributor

Let's use this issue to implement WebView IsJavaScriptAlertEnabled and ExecutionMode Platform Specifics on Windows.

@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants