Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Implement Windows Platform Specifics #5855

Merged
merged 28 commits into from
May 9, 2022

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Apr 6, 2022

Description of Change

Implement Windows Platform Specifics.

  • Editor DetectReadingOrderFromContent.
  • Entry DetectReadingOrderFromContent.
  • Label DetectReadingOrderFromContent.
  • RefreshView RefreshPullDirection.
  • VisualElement AccessKeyHorizontalOffset, AccessKeyPlacement, AccessKey and AccessKeyVerticalOffset.
  • WebView IsJavaScriptAlertEnabled. (webview2 has alerts, but they look bad: Alerts in Blazor and WebView on Windows do not look nice #6961)

Fixes (partially) #5856

@jsuarezruiz jsuarezruiz added the legacy-area-desktop Windows / WinUI / Project Reunion & Mac Catalyst / macOS specifics (Menus & other Controls)) label Apr 7, 2022

namespace Microsoft.Maui.Controls.Platform
{
public static class VisualElementExtensions
{
public static void UpdateAccessKey(this FrameworkElement platformView, View view)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using Microsoft.UI.Xaml.Controls;

namespace Microsoft.Maui.Controls.Platform
{
internal static class AutoSuggestBoxExtensions
{
public static void UpdateIsSpellCheckEnabled(this AutoSuggestBox platformControl, SearchBar searchBar)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{
public partial class WebView
{
public static void MapIsJavaScriptAlertEnabled(WebViewHandler handler, WebView webView)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{
public partial class RefreshView
{
public static void MapRefreshPullDirection(RefreshViewHandler handler, RefreshView refreshView) =>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{
public partial class Label
{
public static void MapDetectReadingOrderFromContent(LabelHandler handler, Label label)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsuarezruiz jsuarezruiz marked this pull request as ready for review April 12, 2022 14:22
@rmarinho rmarinho requested review from PureWeen and rachelkang May 2, 2022 09:22
@Redth Redth added this to the 6.0.300 milestone May 5, 2022
…dows

# Conflicts:
#	src/Controls/samples/Controls.Sample/Controls/EnumPicker.cs
#	src/Controls/samples/Controls.Sample/Pages/PlatformSpecifics/Android/AndroidTabbedPageSwipePage.xaml.cs
#	src/Controls/samples/Controls.Sample/Pages/PlatformSpecifics/Android/AndroidTitleViewPage.xaml.cs
#	src/Controls/src/Core/HandlerImpl/Entry/Entry.cs
#	src/Controls/src/Core/HandlerImpl/VisualElement/VisualElement.cs
#	src/Controls/src/Core/HandlerImpl/WebView/WebView.Android.cs
#	src/Controls/src/Core/HandlerImpl/WebView/WebView.Standard.cs
#	src/Controls/src/Core/HandlerImpl/WebView/WebView.cs
#	src/Controls/src/Core/HandlerImpl/WebView/WebView.iOS.cs
@mattleibow
Copy link
Member

I removed the IsJavaScriptAlertEnabled property because UWP WebView did not support alerts by default, and this was used to make them appear. WebView2 now supports alerts, but it looks bad (#6961)

However, what about promps? And do we do anything for the other platforms.

I opened a new issue to discuss what/how we want to redirect this: #6963

@mattleibow mattleibow requested a review from rachelkang May 9, 2022 19:39
@mattleibow mattleibow dismissed rachelkang’s stale review May 9, 2022 19:41

Comments resolved.

@mattleibow mattleibow merged commit dc4f18d into main May 9, 2022
@mattleibow mattleibow deleted the platform-specific-windows branch May 9, 2022 20:40
@Guandaru6967
Copy link

Guandaru6967 commented Sep 16, 2022

Hi,how can i use the Javascript prompt menu that is built in edge?? My Blazor Maui uses Zoom Web SDk and the permission prompt is in Javascript. How can i make the prompt visible since i can see IsJavascriptEnabled is deprecated?

Target Platform: Windows in .NET MAUI

@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2023
@Eilon Eilon added the t/desktop The issue relates to desktop scenarios (MacOS/MacCatalyst/Windows/WinUI/WinAppSDK) label May 10, 2024
@samhouts samhouts added the fixed-in-6.0.312 Look for this fix in 6.0.312! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed-in-6.0.312 Look for this fix in 6.0.312! legacy-area-desktop Windows / WinUI / Project Reunion & Mac Catalyst / macOS specifics (Menus & other Controls)) platform/windows 🪟 t/desktop The issue relates to desktop scenarios (MacOS/MacCatalyst/Windows/WinUI/WinAppSDK)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants