Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement MaxLength property in EditorHandlers #552

Merged
merged 5 commits into from
Mar 23, 2021
Merged

Implement MaxLength property in EditorHandlers #552

merged 5 commits into from
Mar 23, 2021

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

Implement MaxLength property in EditorHandlers.

Platforms Affected

  • Core
  • iOS
  • Android

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Targets a single property for a single control (or intertwined few properties)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

@mattleibow
Merge branch 'main' into editor-maxlength
a6ecd5d
@mattleibow
Merge remote-tracking branch 'origin/main' into editor-maxlength
9bcb268
@mattleibow
Fixes and things
f63c9d0 
- Reduce a vast amount of copy paste between label, entry and editor
- Add tests for text changes
- Text properly trimmed on iOS
@mattleibow mattleibow merged commit faff612 into main Mar 23, 2021
@mattleibow mattleibow deleted the editor-maxlength branch March 23, 2021 12:15
shyunMin added a commit to shyunMin/maui that referenced this pull request Nov 18, 2022
@shyunMin
[Tizen] Update bottom tabs of Shell (dotnet#552)
4174427 
* [Tizen] Update bottom tabs of Shell

* Apply review feedback

* Update ShellSectionItemView based on PR feedback
shyunMin added a commit to shyunMin/maui that referenced this pull request Nov 18, 2022
@shyunMin
[Tizen] Update bottom tabs of Shell (dotnet#552)
ff8a4ba 
* [Tizen] Update bottom tabs of Shell

* Apply review feedback

* Update ShellSectionItemView based on PR feedback
shyunMin added a commit to shyunMin/maui that referenced this pull request Nov 18, 2022
@shyunMin
[Tizen] Update bottom tabs of Shell (dotnet#552)
ab9bdee 
* [Tizen] Update bottom tabs of Shell

* Apply review feedback

* Update ShellSectionItemView based on PR feedback
shyunMin added a commit to shyunMin/maui that referenced this pull request Nov 24, 2022
@shyunMin
[Tizen] Update bottom tabs of Shell (dotnet#552)
746aca0 
* [Tizen] Update bottom tabs of Shell

* Apply review feedback

* Update ShellSectionItemView based on PR feedback
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Jul 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 27, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattleibow mattleibow mattleibow approved these changes

Assignees
No one assigned
Labels
area-controls-editor Editor area-controls-entry Entry fixed-in-6.0.100-preview.3.2 platform/android 🤖 platform/iOS 🍎
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsuarezruiz @mattleibow @Eilon @samhouts