Make SDK resolution a service #2847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| BuildEventContext.InvalidTaskId)); | ||
| BuildEventContext.InvalidTaskId), | ||
| sdkResolverService, | ||
| _requestEntry.Request.SubmissionId); |
|
|
||
| /// <summary> | ||
| /// Resolves the specified SDK. | ||
| /// </summary> |
There was a problem hiding this comment.
Maybe add a remark here about locking? This does quite a bit of implicit thread synchronization where I would probably expect to see locks. A comment about that could help make it more obvious when locks are taken via the concurrent dictionaries.
| private void HandleRequest(int node, SdkResolverRequest request) | ||
| { | ||
| // Start the background thread which will process queued requests if it has not already been started. | ||
| lock (_lockObject) |
There was a problem hiding this comment.
lock [](start = 12, length = 4)
Duplicate the if (_requestHandler == null) to avoid locking
…at was resolved Add unit tests
| @@ -12,6 +12,7 @@ | |||
|
|
|||
| namespace Microsoft.Build.Engine.UnitTests.BackEnd | |||
| { | |||
| /* | |||
There was a problem hiding this comment.
Can these be adapted? Or delete the file if not.
There was a problem hiding this comment.
My next commit has renamed and updated these tests
Evaluation: Time (ms)
Evaluation: Memory (bytes)
Build: Time (ms)
Build: Memory (bytes)
|
…ImportsAreInPreprocessedOutput by using TestEnvironment to mock SDK resolution
AndyGerlicher
approved these changes
Jan 8, 2018
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A singleton instance handles all resolution. A service hosted in the main node handles build related evaluation on the main node and a service hosted in the out-of-proc node sends requests to the main node for processing.
A cache exists on the main node so that requests are only resolved once per build. The out-of-proc node also caches responses so that an SDK is only resolved once.
Non-build evaluations are not cached and could be slow since there is no way to know if two evaluations are related.
Address the first step in #2803