Support folder name "Sdk" or "sdk" in NuGet SDK resolver #2913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainersigwald
approved these changes
Jan 25, 2018
| if (NativeMethodsShared.IsWindows) | ||
| { | ||
| // Get the installed path and add the expected "Sdk" folder. Windows file systems are not case sensitive | ||
| installedPath = Path.Combine(packageInfo.PathResolver.GetInstallPath(packageInfo.Id, packageInfo.Version), "Sdk"); |
There was a problem hiding this comment.
Move this outside the if and just do if !windows && !exist? seems cleaner to read.
There was a problem hiding this comment.
👍 I messed with the logic so much I forgot to go back and simplify. I ❤️ code reviews
cdmihai
approved these changes
Jan 26, 2018
nguerrera
approved these changes
Jan 26, 2018
akoeplinger
reviewed
Jan 28, 2018
| @@ -203,8 +203,15 @@ private static bool TryGetMSBuildSdkPackageInfo(FallbackPackagePathResolver fall | |||
| return false; | |||
| } | |||
|
|
|||
| // Get the installed path and add the expected "Sdk" folder | |||
| // Get the installed path and add the expected "Sdk" folder. Windows file systems are not case sensitive | |||
There was a problem hiding this comment.
If sdk is the expected/documented casing as mentioned in #2803 (comment) I think we should flip the check around?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since some non-Windows file systems are case sensitive, SDK authors will need to know that the "Sdk" folder is supposed to be capitalized.
This change makes it so that SDK package owners can use "Sdk" or "sdk". See relevant discuss here: #2803 (comment)
There will be a little overhead to check directory existence.