throw on netcoreapp5/6/7/8 #8286
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netcoreapp was [replaced](https://learn.microsoft.com/en-us/dotnet/standard/frameworks#supported-target-frameworks) with net since v5.
|
MSBuild isn't the right place to enforce this decision. NuGet is responsible for determining the set of supported target framework short names; the MSBuild code edited in this PR is a wrapper that exposes the NuGet functionality and shouldn't differ in behavior from calling the NuGet APIs directly. I'd suggest requesting the breaking change from NuGet, which I see you've done with NuGet/Home#12351, so I'm going to close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
netcoreapp was replaced with net since v5. msbuild should stop supporting
<TargetFramework>netcoreapp7.0</TargetFramework>etc. simply because it is wrong and easy to fix at user-end side