ConfiguredProject-level service for determining whether a project is implicitly active #3060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handles the case when the CancellationToken has already been been disposed.
Let's configured-project services await on becoming active.
When the project unloads while we're getting a call back, we reset the cancellation token to inactive state.
davkean
changed the title
|
tag @dotnet/project-system ready for review. |
Pilchie
approved these changes
Dec 19, 2017
| namespace Microsoft.VisualStudio.ProjectSystem | ||
| { | ||
| /// <summary> | ||
| /// Provides properties and events to track the implicit activation of an <see cref="ConfiguredProject"/>. |
| /// </summary> | ||
| internal static class CancellationTokenExtensions | ||
| { | ||
| #pragma warning disable CA1068 // CancellationToken parameters must come last |
There was a problem hiding this comment.
Consider filing a bug to not fire this if the CancellationToken is a this parameter to an extension method.
There was a problem hiding this comment.
| private void OnImplicitlyDeactivated() | ||
| { | ||
| _isImplicitlyActiveSource = new TaskCompletionSource<object>(); | ||
| Thread.MemoryBarrier(); |
There was a problem hiding this comment.
Can you comment why this is required?
jmarolf
reviewed
Dec 19, 2017
| { | ||
| EnsureInitialized(true); | ||
|
|
||
| _version++; |
There was a problem hiding this comment.
Is this going to be called from multiple threads?
natidea
approved these changes
Dec 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new ConfiguredProject-level service that allows services that live within that scope to "await" on being active:
The current API shape matches that needed by
ConfiguredProjectReadyToBuild. It will be extended to support "startup and shutdown" scenarios needed by the language service.Events that enable startup and shutdown scenarios(Will do in a future check-in)