Add a link to show the new Launch Profile UI #7023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewnoakes
added
the
Feature-Project-Properties-Designer
drewnoakes
force-pushed
the
launch-profiles
branch
from
fd27a14 to
b9d45e6
Compare
tmeschter
approved these changes
Mar 31, 2021
This PR has a sibling PR in CPS that makes this API change, so that link action handlers have access to the project context in which they are invoked.
Reinstates the "Debug" page with a single link action that invokes the `OpenLaunchProfilesEditor` command in CPS to open the launch profile editor window.
|
@drewnoakes Do we still need to get this in to enable launch profiles? |
drewnoakes
force-pushed
the
launch-profiles
branch
from
b9d45e6 to
8d8b2d0
Compare
The new launch profile editor has not yet been integrated into the parts of VS that this text suggested was the case. Remove the suggestion for now. We can re-add it once that integration occurs.
dmonroym
approved these changes
Apr 1, 2021
|
When I click the link in 16.10 Preview 2.1, I get an error message box:
Is that expected? Is there another way to get to the dialog? I would like to launch the app with an argument. |
|
@miloush thank you for taking the time to provide this feedback. This bug was caused by one component that was not updated in time for the preview you are using. Newer previews will resolve this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a link action that invokes a command in CPS to show the new Launch Profile UI. The link is displayed on the "Debug" page of the new Project Properties UI.
Sibling CPS PR (Internal): https://devdiv.visualstudio.com/DevDiv/_git/CPS/pullrequest/310621
Microsoft Reviewers: Open in CodeFlow