Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle new LSP InsertReplaceEdit type #8829

Open
allisonchou opened this issue Jun 15, 2023 · 0 comments
Open

Handle new LSP InsertReplaceEdit type #8829

allisonchou opened this issue Jun 15, 2023 · 0 comments
Assignees
@alexgav
Labels
feature-completion tech-debt
Milestone
17.13 Planning

Comments

@allisonchou
Copy link
Contributor

allisonchou commented Jun 15, 2023 •
edited
Loading

The LSP spec now contains the InsertReplaceEdit type, which can be used in place of TextEdits in some places (such as completion items). We should update our code to handle this new type.

https://microsoft.github.io/language-server-protocol/specifications/lsp/3.18/specification/#insertReplaceEdit

The VS + VS Code language clients don't seem to support this type yet, so this likely isn't urgent.
@ghost ghost added the untriaged label Jun 15, 2023
@allisonchou allisonchou mentioned this issue Jun 20, 2023
Closed
@phil-allen-msft phil-allen-msft added this to the 17.8 Planning milestone Jun 23, 2023
@ghost ghost removed the untriaged label Jun 23, 2023
@ryzngard ryzngard mentioned this issue Jul 1, 2024
Merged
ryzngard added a commit that referenced this issue Jul 3, 2024
@ryzngard
Handle InsertReplaceEdit for completion (#10563)
ef0a3b0 
Partially complete #8829
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexgav alexgav

Labels
feature-completion tech-debt
Projects
None yet
Milestone
17.13 Planning
Development

No branches or pull requests
3 participants
@alexgav @allisonchou @phil-allen-msft