Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement precise semantic token range requests and compare against current algorithm #9092

Closed
phil-allen-msft opened this issue Aug 4, 2023 · 1 comment
Closed

Implement precise semantic token range requests and compare against current algorithm #9092

phil-allen-msft opened this issue Aug 4, 2023 · 1 comment
Assignees
@maryamariyan
Milestone
17.8

Comments

@phil-allen-msft
Copy link
Member

phil-allen-msft commented Aug 4, 2023 •
edited
Loading

For Razor semantic range coloring, the LSP asks Roslyn to generate semantic tokens for a range from the 'earliest point' to the 'latest point' in the generated C# document that maps to the visible content. It has been suggested that the overall performance of the system will be faster if a set of precise calls are made instead of one encompassing call. We should implement this alternative and compare against the existing algorithm.
@ghost ghost added the untriaged label Aug 4, 2023
@phil-allen-msft phil-allen-msft added this to the 17.8 P2 milestone Aug 4, 2023
@ghost ghost removed the untriaged label Aug 4, 2023
maryamariyan added a commit that referenced this issue Aug 23, 2023
@maryamariyan
Trims range when requesting for semantic tokens
f1ac45a 
- Using feature flags

Contributes to #9092
maryamariyan added a commit that referenced this issue Aug 23, 2023
@maryamariyan
Trims range when requesting for semantic tokens
17025cd 
- Using feature flags

Contributes to #9092
This was referenced Aug 23, 2023
Merged
Closed
maryamariyan added a commit to dotnet/vscode-csharp that referenced this issue Sep 6, 2023
@maryamariyan
Modify the data property of the SemanticTokensResponse class.
8c3053c 
- Changes data to take an array of arrays of number type

Related to dotnet/razor#9092
@maryamariyan maryamariyan mentioned this issue Sep 6, 2023
Merged
@phil-allen-msft phil-allen-msft modified the milestones: 17.8 P2, 17.8 P3 Sep 6, 2023
davidwengier pushed a commit to dotnet/vscode-csharp that referenced this issue Sep 8, 2023
@maryamariyan @davidwengier
Modify the data property of the SemanticTokensResponse class.
573326e 
- Changes data to take an array of arrays of number type

Related to dotnet/razor#9092
@maryamariyan
Copy link
Member

Fixed by #9154
Follow up PR to ingest changes by VS Code is in dotnet/vscode-csharp#6304

maryamariyan added a commit that referenced this issue Sep 20, 2023
@maryamariyan
Ingest new roslyn endpoint to get semantic tokens for precise ranges
b45987d 
Contributes to #9092
@maryamariyan maryamariyan mentioned this issue Sep 20, 2023
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Oct 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@maryamariyan maryamariyan

Labels
None yet
Projects
None yet
Milestone
17.8
Development

No branches or pull requests
2 participants
@maryamariyan @phil-allen-msft