Make network paths be network paths #10191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgav
approved these changes
Apr 1, 2024
| @@ -25,7 +25,20 @@ public void Normalize_Windows_StripsPrecedingSlash() | |||
| } | |||
|
|
|||
| [Fact] | |||
| public void Normalize_IgnoresUNCPaths() | |||
| public void Normalize_NormalizesPathsWithSlashAtPositionOne() | |||
There was a problem hiding this comment.
Nit: could probably use Thoery for the tests
DustinCampbell
approved these changes
Apr 1, 2024
ryzngard
approved these changes
Apr 1, 2024
This was referenced Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10192
Seems we were normalizing
\\computername\pathto//computername/pathwhich meant it wasn't a network path any more. Now we normalize to\\computername/pathwhich seems to work fine 🤷♂️