Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release/dev17.11 to main #10727

Merged
merged 11 commits into from
Aug 13, 2024
Merged

Merge release/dev17.11 to main #10727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
085aa32
Upgrade testing analyzers to address CG alert.
333fred Aug 6, 2024
6353caa
Manually reference Microsoft.IO.Redist 6.0.1 where needed to fix CG a…
333fred Aug 6, 2024
47438b5
Merge remote-tracking branch 'upstream/release/dev17.8' into merges/r…
333fred Aug 6, 2024
a11f5d7
Merge release/dev17.8 to release/dev17.10 (#10710)
dotnet-bot Aug 6, 2024
f8c1f45
Update System.Formats.Asn1 to address CG alert.
333fred Aug 6, 2024
b5c4983
Upgrade System.Security.Cryptography.Xml to avoid CG alerts.
333fred Aug 6, 2024
82ddac1
Merge remote-tracking branch 'upstream/release/dev17.10' into merges/…
333fred Aug 12, 2024
ff768a6
Merge release/dev17.10 to release/dev17.11 (#10711)
dotnet-bot Aug 13, 2024
2dca8f9
Merge remote-tracking branch 'upstream/release/dev17.11' into merges/…
davidwengier Aug 13, 2024
194ef8c
Fix CG issue with MS.IO.Redist
jaredpar Aug 12, 2024
7db021d
more
jaredpar Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,5 +122,13 @@
<PackageVersion Include="xunit.extensibility.execution" Version="$(_XunitPackageVersion)" />
<PackageVersion Include="xunit.runner.utility" Version="2.4.1" />
<PackageVersion Include="Xunit.StaFact" Version="1.2.46-alpha" />

<!--
These package references exist solely to fix component governance issues. Referencing them here
at the appropriate version, in combination with using CentralPackageTransitivePinningEnabled, will
ensure the correct version is used in all places
-->
<PackageVersion Include="Microsoft.IO.Redist" Version="6.0.1" />
<PackageVersion Include="System.Formats.Asn1" Version="8.0.1" />
</ItemGroup>
</Project>
3 changes: 3 additions & 0 deletions ...ExternalAccess.LegacyEditor/Microsoft.AspNetCore.Razor.ExternalAccess.LegacyEditor.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@
<ItemGroup>
<PackageReference Include="Microsoft.VisualStudio.ComponentModelHost" PrivateAssets="all" />
<PackageReference Include="Microsoft.VisualStudio.Shell.Framework" PrivateAssets="all"/>
<!-- Manually upgrade to address CG alert. When the VS packages
pull in the right version, this can be removed. -->
<PackageReference Include="Microsoft.IO.Redist" Condition="'$(TargetFramework)' == '$(DefaultNetFxTargetFramework)'" PrivateAssets="all"/>
</ItemGroup>

<ItemGroup>
Expand Down
1 change: 1 addition & 0 deletions ...icrosoft.AspNetCore.Razor.LanguageServer/Microsoft.AspNetCore.Razor.LanguageServer.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
<PackageReference Include="Microsoft.CommonLanguageServerProtocol.Framework" PrivateAssets="all" />
<PackageReference Include="Microsoft.Extensions.DependencyInjection" />
<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" />
<PackageReference Include="Microsoft.IO.Redist" Condition="'$(TargetFramework)' == '$(DefaultNetFxTargetFramework)'" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not remove this packageref?


<!--
Pinning packages to avoid misaligned reference CI failures.
Expand Down
3 changes: 3 additions & 0 deletions ...geServer.ContainedLanguage/Microsoft.VisualStudio.LanguageServer.ContainedLanguage.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@
<PackageReference Include="Microsoft.VisualStudio.LanguageServer.Protocol.Extensions" />
<PackageReference Include="Microsoft.VisualStudio.LanguageServer.Protocol.Internal" />
<PackageReference Include="Microsoft.VisualStudio.LanguageServer.Client.Implementation" />
<!-- Manually upgrade to address CG alert. When the VS packages
pull in the right version, this can be removed. -->
<PackageReference Include="Microsoft.IO.Redist" Condition="'$(TargetFramework)' == '$(DefaultNetFxTargetFramework)'" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this one

</ItemGroup>

<ItemGroup>
Expand Down
5 changes: 4 additions & 1 deletion ....VisualStudio.LanguageServices.Razor/Microsoft.VisualStudio.LanguageServices.Razor.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@

<PackageReference Include="Microsoft.VisualStudio.LiveShare" />
<PackageReference Include="Microsoft.VisualStudio.Shell.15.0" />
<!-- Manually upgrade to address CG alert. When the VS packages
pull in the right version, this can be removed. -->
<PackageReference Include="Microsoft.IO.Redist" Condition="'$(TargetFramework)' == '$(DefaultNetFxTargetFramework)'" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one too


<!--
Pinning packages to avoid misaligned reference CI failures.
Expand Down Expand Up @@ -181,4 +184,4 @@

<Import Project="..\..\..\Shared\Microsoft.AspNetCore.Razor.Serialization.Json\Microsoft.AspNetCore.Razor.Serialization.Json.projitems" Label="Shared" />

</Project>
</Project>
3 changes: 3 additions & 0 deletions ...dio.RazorExtension.Dependencies/Microsoft.VisualStudio.RazorExtension.Dependencies.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@
<ItemGroup>
<!-- To include the ProvideCodeBase attribute type. -->
<PackageReference Include="Microsoft.VisualStudio.Shell.15.0" />
<!-- Manually upgrade to address CG alert. When the VS packages
pull in the right version, this can be removed. -->
<PackageReference Include="Microsoft.IO.Redist" Condition="'$(TargetFramework)' == '$(DefaultNetFxTargetFramework)'" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More

</ItemGroup>

<!-- Reference the LSP protocol dlls so that we can include them in the code base and output them with the VSIX. -->
Expand Down
3 changes: 3 additions & 0 deletions ...or/src/Microsoft.VisualStudio.RazorExtension/Microsoft.VisualStudio.RazorExtension.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,9 @@
<PackageReference Include="Microsoft.NET.Sdk.Razor" IncludeAssets="None" PrivateAssets="All" GeneratePathProperty="true" />
<PackageReference Include="System.Resources.Extensions" />
<PackageReference Include="Microsoft.VisualStudio.Shell.15.0" />
<!-- Manually upgrade to address CG alert. When the VS packages
pull in the right version, this can be removed. -->
<PackageReference Include="Microsoft.IO.Redist" Condition="'$(TargetFramework)' == '$(DefaultNetFxTargetFramework)'" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moar.


<!--
Pinning packages to avoid misaligned reference CI failures.
Expand Down
3 changes: 3 additions & 0 deletions ....VisualStudio.Razor.IntegrationTests/Microsoft.VisualStudio.Razor.IntegrationTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@
<PackageReference Include="Microsoft.VisualStudio.Extensibility.Testing.SourceGenerator" />
<PackageReference Include="Microsoft.VisualStudio.Language.Intellisense" />
<PackageReference Include="NuGet.VisualStudio" />
<!-- Manually upgrade to address CG alert. When the VS packages
pull in the right version, this can be removed. -->
<PackageReference Include="Microsoft.IO.Redist" Condition="'$(TargetFramework)' == '$(DefaultNetFxTargetFramework)'" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not remove this packageref?

<PackageReference Include="Microsoft.Internal.VisualStudio.Shell.Framework" />
<PackageReference Include="xunit.runner.utility" />
<PackageReference Include="xunit.runner.console" Version="$(XUnitRunnerConsoleVersion)" IsImplicitlyDefined="true" PrivateAssets="all" Publish="true" />
Expand Down