Fix formatting of escaped at signs #11462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgav
reviewed
Feb 7, 2025
| body { | ||
| background-color: lightblue; | ||
| } | ||
| } |
There was a problem hiding this comment.
Should we have purposely bad formatting here to demonstrate our formatter ignores it in this case?
There was a problem hiding this comment.
Our test infra doesn't know how to format CSS or TypeScript, so it's all "bad formatting" as far as the C# formatter is concerned.
There was a problem hiding this comment.
Right, my suggestion was to have bad formatting in input an output (extra or missing space, bad indentation) so it's obvious we are not trying to format in that case. No big deal.
This was referenced Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noticed this while mucking around in OrchardCode