Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to view the formatting document to the syntax visualizer #11463

Merged

Conversation

davidwengier
Copy link
Member

Figured this might come in handy, possibly for some specific date in the next 2 weeks.

I tried to make a drop down button instead of just adding a new button, and I couldn't work out how to do it :(

@davidwengier davidwengier requested a review from a team as a code owner February 6, 2025 23:39
@alexgav
Copy link
Contributor

alexgav commented Feb 7, 2025

@@ -31,6 +31,7 @@ internal class SyntaxVisualizerToolWindow : ToolWindowPane
private const int CmdIdShowAllTagHelpers = 0x0113;
private const int CmdIdShowInScopeTagHelpers = 0x0114;
private const int CmdIdShowReferencedTagHelpers = 0x0115;
private const int CmdidShowFormattingDocument = 0x0117;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7

Nit: intentionally skipped 0x0116?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, lol, I used that is to try to get a dropdown working, but the vsct magic eluded me. I will update :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no magic! VS is just GUIDs and ints all the way down. 😁

Copy link
Contributor

@alexgav alexgav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@davidwengier
Copy link
Member Author

I didn't try a combo, but I tried a menu and followed the instructions to the letter and then gave up :)

@davidwengier davidwengier merged commit 8d6fb3a into dotnet:main Feb 8, 2025
12 checks passed
@davidwengier davidwengier deleted the FormattingDocumentInSyntaxVisualizer branch February 8, 2025 01:04
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants