Support C# onTypeFormatting in Razor LSP (Part 1) #2213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajaybhargavb
requested review from
noahbkim,
NTaylorMullen,
ryanbrandenburg and
TanayParikh
as code owners
ajaybhargavb
commented
Jul 10, 2020
...or/src/Microsoft.AspNetCore.Razor.LanguageServer/Formatting/DefaultRazorFormattingService.cs
Outdated
Show resolved
Hide resolved
TanayParikh
approved these changes
Jul 10, 2020
src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/IRazorMapToDocumentEditsHandler.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/RazorMapToDocumentEditsParams.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/RazorMapToDocumentEditsParams.cs
Show resolved
Hide resolved
src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/RazorMapToDocumentEditsResponse.cs
Outdated
Show resolved
Hide resolved
.../src/Microsoft.VisualStudio.LanguageServerClient.Razor/HtmlCSharp/OnTypeFormattingHandler.cs
Show resolved
Hide resolved
src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/RazorLanguageEndpoint.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/RazorLanguageEndpoint.cs
Outdated
Show resolved
Hide resolved
ryanbrandenburg
approved these changes
Jul 10, 2020
...or/src/Microsoft.AspNetCore.Razor.LanguageServer/Formatting/DefaultRazorFormattingService.cs
Outdated
Show resolved
Hide resolved
...or/src/Microsoft.AspNetCore.Razor.LanguageServer/Formatting/DefaultRazorFormattingService.cs
Outdated
Show resolved
Hide resolved
NTaylorMullen
approved these changes
Jul 13, 2020
...or/src/Microsoft.AspNetCore.Razor.LanguageServer/Formatting/DefaultRazorFormattingService.cs
Outdated
Show resolved
Hide resolved
...or/src/Microsoft.AspNetCore.Razor.LanguageServer/Formatting/DefaultRazorFormattingService.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/RazorLanguageEndpoint.cs
Outdated
Show resolved
Hide resolved
| @@ -158,6 +157,28 @@ public async override Task<TextEdit[]> RemapTextEditsAsync(Uri uri, TextEdit[] e | |||
| return remappedEdits; | |||
| } | |||
|
|
|||
| public async override Task<TextEdit[]> RemapFormattedTextEditsAsync(Uri uri, TextEdit[] edits, FormattingOptions options, CancellationToken cancellationToken) | |||
There was a problem hiding this comment.
This signature should also include the snapshot because we can't know if the consumer is going to do more async work and therefore need to re-check document versions
There was a problem hiding this comment.
Will add in the next PR
src/Razor/src/Microsoft.VisualStudio.LanguageServerClient.Razor/HtmlCSharp/InitializeHandler.cs
Show resolved
Hide resolved
.../src/Microsoft.VisualStudio.LanguageServerClient.Razor/HtmlCSharp/OnTypeFormattingHandler.cs
Outdated
Show resolved
Hide resolved
ajaybhargavb
force-pushed
the
ajbaaska/ontypeformatting
branch
from
61bf27f to
823f525
Compare
* Core formatting logic wip * Another validation pass and address feedback * More feedback
ajaybhargavb
force-pushed
the
ajbaaska/ontypeformatting
branch
from
bdaa03c to
c5bdc3b
Compare
…t part 3/3) (#2334) * Added tests for onTypeFormatting and friends * Feedback
ajaybhargavb
added
the
auto-merge
|
Hello @ajaybhargavb! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/dotnet/aspnetcore/issues/23419