Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unrevert "Bump version to 8" #9303

Closed
wants to merge 2 commits into from
Closed

Conversation

jjonescz
Copy link
Member

@jjonescz jjonescz commented Sep 20, 2023

@jaredpar
Copy link
Member

I feel like this should be titled "Revert Revert Revert" 😉

@jjonescz jjonescz marked this pull request as ready for review October 18, 2023 08:38
@jjonescz jjonescz requested review from a team as code owners October 18, 2023 08:38
@jjonescz
Copy link
Member Author

VS insertion looks good. We will probably need to somehow insert both WebTools and Razor at the same time.

@dotnet/razor-compiler for reviews

@333fred
Copy link
Member

333fred commented Oct 18, 2023

We need to get assembly redirects into devenv so we don't need to do coordinated insertions with WebTools all the time, or this will be untenable long term. We'll need to update https://devdiv.visualstudio.com/DevDiv/_git/VS?path=/src/ProductData/AssemblyVersions.tt&version=GBmain&line=147&lineEnd=149&lineStartColumn=1&lineEndColumn=1&lineStyle=plain&_a=contents, and work with Tiger to update these versions automatically with the insertion tool.

Hopefully, with such a change, we won't need to update WebTools at all.

@DustinCampbell
Copy link
Member

@jjonescz, @jaredpar, @333fred - is this PR still needed or can it be closed after 6 months of inactivity?

@jjonescz
Copy link
Member Author

jjonescz commented Apr 22, 2024

is this PR still needed or can it be closed after 6 months of inactivity?

I think we still want to change Razor's version from 7 to 8 or even 9 now. But some infra changes are needed first so the insertions handle such version changes automatically.

That being said, I will close this and open new PR bumping to version 9 when it works.

@jjonescz jjonescz closed this Apr 22, 2024
@jjonescz jjonescz deleted the v8-unrevert branch April 22, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants