Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Start inserting platform agnostic language server + telemetry #9483

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

allisonchou
Copy link
Contributor

Updates docs to reflect this change (will wait to merge this PR until that PR is in)

@allisonchou allisonchou requested review from davidwengier and a team October 26, 2023 20:34
@allisonchou allisonchou changed the title [Documentation] Starting inserting platform agnostic language server + telemetry [Documentation] Start inserting platform agnostic language server + telemetry Oct 26, 2023
@davidwengier
Copy link
Member

I'm guessing the experience is better using a platform specific package, right? Otherwise the obvious question is: Why doesn't everyone just get the platform agnostic package? We don't have much in the way of platform specific code, do we?

@allisonchou
Copy link
Contributor Author

Why doesn't everyone just get the platform agnostic package? We don't have much in the way of platform specific code, do we?

According to DavidB, Roslyn builds platform-specific language servers with ReadyToRun which makes it faster compared to the language agnostic server. I don't think(?) Razor uses ReadyToRun today so there's not much benefit for us, but it could be an optimization that we implement in the future

@allisonchou allisonchou merged commit 0255da9 into main Oct 27, 2023
@allisonchou allisonchou deleted the dev/allichou/UpdateDocPlatformAgnostic branch October 27, 2023 22:35
@ghost ghost added this to the Next milestone Oct 27, 2023
@jjonescz jjonescz modified the milestones: Next, 17.9 P1 Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants