Record-structs: don't offer to complete destructor (#52408)

dotnet · Apr 4, 2021 · 57091b1 · 57091b1
1 parent 1ea41c7
commit 57091b1
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/...EditorFeatures/CSharpTest/Completion/CompletionProviders/SymbolCompletionProviderTests.cs b/...EditorFeatures/CSharpTest/Completion/CompletionProviders/SymbolCompletionProviderTests.cs
@@ -7482,13 +7482,12 @@ struct C
 {
    ~$$
 }";
-            await VerifyItemExistsAsync(markup, "C");
+            await VerifyItemIsAbsentAsync(markup, "C");
         }
 
         [Theory, Trait(Traits.Feature, Traits.Features.Completion)]
         [InlineData("record")]
         [InlineData("record class")]
-        [InlineData("record struct")]
         public async Task RecordDestructor(string record)
         {
             var markup = $@"
@@ -7499,6 +7498,17 @@ public async Task RecordDestructor(string record)
             await VerifyItemExistsAsync(markup, "C");
         }
 
+        [Fact, Trait(Traits.Feature, Traits.Features.Completion)]
+        public async Task RecordStructDestructor()
+        {
+            var markup = $@"
+record struct C
+{{
+   ~$$
+}}";
+            await VerifyItemIsAbsentAsync(markup, "C");
+        }
+
         [Fact, Trait(Traits.Feature, Traits.Features.Completion)]
         public async Task FieldAvailableInBothLinkedFiles()
         {

diff --git a/...redUtilitiesAndExtensions/Workspace/CSharp/Extensions/ContextQuery/CSharpSyntaxContext.cs b/...redUtilitiesAndExtensions/Workspace/CSharp/Extensions/ContextQuery/CSharpSyntaxContext.cs
@@ -201,7 +201,7 @@ private static CSharpSyntaxContext CreateContextWorker(Workspace? workspace, Sem
 
             var isDestructorTypeContext = targetToken.IsKind(SyntaxKind.TildeToken) &&
                                             targetToken.Parent.IsKind(SyntaxKind.DestructorDeclaration) &&
-                                            targetToken.Parent.Parent.IsKind(SyntaxKind.ClassDeclaration, SyntaxKind.StructDeclaration, SyntaxKind.RecordDeclaration, SyntaxKind.RecordStructDeclaration);
+                                            targetToken.Parent.Parent.IsKind(SyntaxKind.ClassDeclaration, SyntaxKind.RecordDeclaration);
 
             // Typing a dot after a numeric expression (numericExpression.) 
             // - maybe a start of MemberAccessExpression like numericExpression.Member.