You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In order for MSBuild determinism and dependency validation to work, we need to find the .editorconfig files before we invoke the CoreCompile target (since is doing up-to-date checking) and also before the Csc/Vbc task runs, because we want that to be reasonably deterministic. Therefore, we need a build task to take the compiler inputs and walk around the file system locating the .editorconfig files that will apply so they can be passed.
Open questions
Which binary does this build task live in? The task itself has no dependency on Roslyn at all, so it could live anywhere. Should it live in MSBuild core build tasks or in our CodeAnalysis build tasks? I'm leaning towards the latter, as it has some affinity with our scenarios and will likely rev with it. @jaredpar, thoughts? This reminds me of the new task that you're creating for the reference assembly copying. It's another ancillary task that supports Csc/Vbc but might be consumed in other places.
Where does the target that invokes the task live in? @jaredpar and @agocke do you have guidance/rules for what should and shouldn't go within our .targets that we bundle in the toolset packages vs. the core projects?
Is there any code this can share from the core .editorconfig support? @olegtk is there any source that might be usable here from your implementation? This is just file discovery, so we don't need the full logic.
Implementation notes
The order of the output must be stable to support determinism builds. The actual sort criteria won't matter, but must be stable.
The text was updated successfully, but these errors were encountered:
In order for MSBuild determinism and dependency validation to work, we need to find the .editorconfig files before we invoke the CoreCompile target (since is doing up-to-date checking) and also before the Csc/Vbc task runs, because we want that to be reasonably deterministic. Therefore, we need a build task to take the compiler inputs and walk around the file system locating the .editorconfig files that will apply so they can be passed.
Open questions
Implementation notes
The order of the output must be stable to support determinism builds. The actual sort criteria won't matter, but must be stable.
The text was updated successfully, but these errors were encountered: