Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow the list of .editorconfig files through the compiler front end #18210

Closed
jasonmalinowski opened this issue Mar 27, 2017 · 5 comments
Closed

Comments

@jasonmalinowski
Copy link
Member

Once we have the list of .editorconfig files determined, we need to get them through the compiler APIs. The expectation is these are expressed in the same form roughly as source files:

  1. They go into another input into the Csc/Vbc tasks.
  2. We convert those to /editorconfig switches, which are a list of file names after that. Same as any other switched input.
  3. We parse those through and still represent as files in the parsed command line options, again same as everything else.
@Pilchie Pilchie added this to the 15.3 milestone Mar 29, 2017
@Pilchie Pilchie modified the milestones: 15.6, 15.3 May 26, 2017
@Pilchie
Copy link
Member

Pilchie commented May 26, 2017

Sadly, this editorconfig work isn't going to fit for 15.3, but we're going to continue targeting the next foundation update.

@dpoeschl dpoeschl modified the milestones: 15.5, 15.later Sep 21, 2017
@dpoeschl
Copy link
Contributor

Moving .editorconfig work to 15.later.

@agocke
Copy link
Member

agocke commented Jun 14, 2018

Done in #27232

@agocke agocke closed this as completed Jun 14, 2018
@smitpatel
Copy link

@agocke - Which milestone (or VS version) did this go in? Milestone here is 16.0 but in PR it is 15.8

@agocke
Copy link
Member

agocke commented Jun 14, 2018

16.0 is right. I've removed the milestone from the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants